Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Set up the presets #95

Merged
merged 8 commits into from
Apr 6, 2018
Merged

ENH: Set up the presets #95

merged 8 commits into from
Apr 6, 2018

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Mar 29, 2018

Description

Use the presets recently added to pcdsdevices. Create the presets/beamline and presets/proposalrunnum directories.

Motivation and Context

The people have spoken. We've split between the beamline presets that are permanent and the experiment presets that are not.

How Has This Been Tested?

Assume presets work in pcdsdevices, make sure we've set up the paths here.

Where Has This Been Documented?

In pcdsdevices

This will definitely fail on travis until we cut a new release for pcdsdevices with the presets.

@ZLLentz ZLLentz requested a review from teddyrendahl March 29, 2018 22:08
@ZLLentz
Copy link
Member Author

ZLLentz commented Mar 29, 2018

I'd like to have your opinions on:

  • paths, are presets/beamline and presets/ls2516 good for the folders?
  • function calls, currently the set is:
motor.presets.add_beamline
motor.presets.add_experiment
motor.presets.add_here_beamline
motor.presets.add_here_experiment

But I'm not sure if these should be shorter or changed, etc. of they are ok as is.

@teddyrendahl
Copy link
Contributor

If you change this to pcdsdevices>v0.5.0 we can see it pass on the -dev build at least.

@teddyrendahl
Copy link
Contributor

Tempted to change add_experiment to add_exp? Just a thought. Can't think of an appropriate shortening of beamline ... add_hutch. I don't know.

I'm fine with the YAML file paths.

Copy link
Contributor

@teddyrendahl teddyrendahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good. Waiting for pcdsdevices release.

@teddyrendahl teddyrendahl added this to the 0.3.0 milestone Apr 5, 2018
@ZLLentz
Copy link
Member Author

ZLLentz commented Apr 5, 2018

Your shortenings seem appropriate. Let's sit on this just a bit longer, I want to get it in right before cutting the pcds-envs release.

@codecov-io
Copy link

Codecov Report

Merging #95 into master will decrease coverage by 0.51%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   97.63%   97.12%   -0.52%     
==========================================
  Files          15       15              
  Lines         677      695      +18     
==========================================
+ Hits          661      675      +14     
- Misses         16       20       +4
Impacted Files Coverage Δ
hutch_python/load_conf.py 98.66% <100%> (+0.15%) ⬆️
hutch_python/bug.py 87.12% <0%> (-3.69%) ⬇️
hutch_python/constants.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a46c6d...311b550. Read the comment docs.

@ZLLentz ZLLentz merged commit 591eda6 into pcdshub:master Apr 6, 2018
@ZLLentz ZLLentz deleted the presets branch April 12, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants