-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Set up the presets #95
Conversation
I'd like to have your opinions on:
But I'm not sure if these should be shorter or changed, etc. of they are ok as is. |
If you change this to |
Tempted to change I'm fine with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look good. Waiting for pcdsdevices release.
Your shortenings seem appropriate. Let's sit on this just a bit longer, I want to get it in right before cutting the pcds-envs release. |
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 97.63% 97.12% -0.52%
==========================================
Files 15 15
Lines 677 695 +18
==========================================
+ Hits 661 675 +14
- Misses 16 20 +4
Continue to review full report at Codecov.
|
Description
Use the presets recently added to
pcdsdevices
. Create thepresets/beamline
andpresets/proposalrunnum
directories.Motivation and Context
The people have spoken. We've split between the
beamline
presets that are permanent and theexperiment
presets that are not.How Has This Been Tested?
Assume presets work in
pcdsdevices
, make sure we've set up the paths here.Where Has This Been Documented?
In
pcdsdevices
This will definitely fail on travis until we cut a new release for
pcdsdevices
with the presets.