Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Rename qs.cfg to web.cfg #91

Merged
merged 3 commits into from
Apr 6, 2018
Merged

MAINT: Rename qs.cfg to web.cfg #91

merged 3 commits into from
Apr 6, 2018

Conversation

teddyrendahl
Copy link
Contributor

Description

Originally the configuration file was for the Questionnaire alone so it was given the specific name qs.cfg. In reality this information is useful for all the pswww applications so we should look for a more general name like web.cfg.

How Has This Been Tested?

Tests are now done with web.cfg file

Where Has This Been Documented?

References to qs.cfg have been changed to web.cfg

@codecov-io
Copy link

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          14       14           
  Lines         560      560           
=======================================
  Hits          553      553           
  Misses          7        7
Impacted Files Coverage Δ
hutch_python/qs_load.py 92.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab1d18...9f09b88. Read the comment docs.

@teddyrendahl teddyrendahl requested a review from ZLLentz March 21, 2018 22:55
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. Do we leave this unmerged until we're about ready to tag?

@teddyrendahl
Copy link
Contributor Author

Agreed. We might need a better system for delaying docs to make sure that our online documentation stays in lock with our released environments in general. We'll see how often this comes up.

@teddyrendahl teddyrendahl added this to the 0.3.0 milestone Mar 23, 2018
@ZLLentz ZLLentz merged commit e1bf45d into pcdshub:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants