Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: for pcdsdaq changes #133

Merged
merged 7 commits into from
Jun 27, 2018
Merged

FIX: for pcdsdaq changes #133

merged 7 commits into from
Jun 27, 2018

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Jun 7, 2018

Description

  • Stop using deprecated platform argument
  • Retire hutch_python.daq since it boils down to a one-liner
  • Rework plan_defaults for usability, future-proofing, and doing a similar thing as nsls-ii. Now there will be bp, bps, bpp that are intelligently filled will all available plans, skipping the other things in the module like imported modules for clean user namespaces.

Motivation and Context

The pcds-envs daily broke because of the plan_defaults module, and I thought I'd clean it up while I was there.

How Has This Been Tested?

It feels good when I tried it out.

Where Has This Been Documented?

Adjusted docs and added a note to release notes.

@codecov-io
Copy link

codecov-io commented Jun 27, 2018

Codecov Report

Merging #133 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   96.93%   96.98%   +0.05%     
==========================================
  Files          15       14       -1     
  Lines         783      797      +14     
==========================================
+ Hits          759      773      +14     
  Misses         24       24
Impacted Files Coverage Δ
hutch_python/plan_defaults.py 100% <100%> (ø) ⬆️
hutch_python/load_conf.py 98.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3aa36...2496fd5. Read the comment docs.

@ZLLentz ZLLentz merged commit 03e6075 into pcdshub:master Jun 27, 2018
@ZLLentz ZLLentz deleted the daq-api branch October 17, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants