Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch LookupError if message has no Subject header #1614

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Catch LookupError if message has no Subject header #1614

merged 1 commit into from
Apr 12, 2023

Conversation

matclab
Copy link

@matclab matclab commented Apr 12, 2023

Close #1613

kbingham
kbingham approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@kbingham kbingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - I have a patch identical to this, so I've hit this too.
Sorry - I should have posted it as a PR! but this looks good to me! (and the equivalent has been thoroughly tested for over a year in my local branch)

pazz
pazz approved these changes Apr 12, 2023
View reviewed changes
Copy link
Owner

@pazz pazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe. cheers!

@pazz pazz merged commit 6ffeff9 into pazz:master Apr 12, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazz pazz pazz approved these changes

@kbingham kbingham kbingham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LookupError when displaying inbox with notmuch backend
3 participants
@matclab @kbingham @pazz