Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow zero amount items #79

Merged
merged 1 commit into from
May 5, 2023
Merged

Allow zero amount items #79

merged 1 commit into from
May 5, 2023

Conversation

VuorelaJ-P
Copy link
Contributor

@VuorelaJ-P VuorelaJ-P commented Apr 24, 2023 •
edited
Loading

Description

  • Allow item with zero amount
  • Change item price test to have data provider
  • Add validation and test for minimum and maximum amount, as well as test for above maximum
  • Remove useless sub versions from workflow actions
  • Add datatype assertion to risky test without any assertion

fix #78

@loueranta-paytrail loueranta-paytrail merged commit 2b17aca into master May 5, 2023
@loueranta-paytrail loueranta-paytrail deleted the fixUnitPriceValidationForZeroAmount branch May 5, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taiteilija Taiteilija Taiteilija approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item validation fails if unitPrice is 0
3 participants
@VuorelaJ-P @Taiteilija @loueranta-paytrail