Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve refundRequest Validation #77

Merged
merged 1 commit into from
May 5, 2023
Merged

Improve refundRequest Validation #77

merged 1 commit into from
May 5, 2023

Conversation

VuorelaJ-P
Copy link
Contributor

@VuorelaJ-P VuorelaJ-P commented Apr 19, 2023 •
edited
Loading

Description

  • Require refund amount only if items are not set
  • Test refund request exceptions individually, without message itself, this makes changing messages easier

fix #72

Taiteilija
Taiteilija previously approved these changes May 2, 2023
View reviewed changes
@VuorelaJ-P VuorelaJ-P force-pushed the improveRefundRequestValidation branch from cccd483 to 2bb8f34 Compare May 5, 2023 09:43
@loueranta-paytrail loueranta-paytrail merged commit cdee831 into master May 5, 2023
@loueranta-paytrail loueranta-paytrail deleted the improveRefundRequestValidation branch May 5, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loueranta-paytrail loueranta-paytrail loueranta-paytrail approved these changes

@Taiteilija Taiteilija Taiteilija left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for item level refunds
3 participants
@VuorelaJ-P @Taiteilija @loueranta-paytrail