Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/payment response fields #53

Merged
merged 10 commits into from
Nov 15, 2022
Merged

Add/payment response fields #53

merged 10 commits into from
Nov 15, 2022

Conversation

Saggre
Copy link
Contributor

@Saggre Saggre commented Oct 24, 2022

Related tickets & documents

Description

  • Fix PaymentResponse function and phpdoc types
  • Add missing fields to PaymentResponse model
  • Simplify PaymentReponse property binder setters
  • Add base test case for payment request tests to avoid code duplication
  • Add tests for new payment response fields
  • Add some style fixes according to phpcs rules

Remember to add new classes to classmap before testing

composer dump-autoload
composer test

Lmk if you want any changes

@loueranta-paytrail loueranta-paytrail merged commit db605eb into paytrail:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VuorelaJ-P VuorelaJ-P VuorelaJ-P approved these changes

@tommi-martin tommi-martin Awaiting requested review from tommi-martin

@Taiteilija Taiteilija Awaiting requested review from Taiteilija

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saggre @VuorelaJ-P @loueranta-paytrail