Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment report endpoint #40

Merged
merged 13 commits into from
Sep 2, 2022
Merged

Conversation

VuorelaJ-P
Copy link
Contributor

Description

Add payment report request endpoint

Copy link
Contributor

@tommi-martin tommi-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the unexpected change in in settlements endpoint?

Other than that the code looks good, left a couple of optional fine-tuning comments

README.md Show resolved Hide resolved
src/Client.php Show resolved Hide resolved
src/Request/ReportRequest.php Show resolved Hide resolved
src/Request/ReportRequest.php Show resolved Hide resolved
tests/ClientTest.php Outdated Show resolved Hide resolved
src/Request/ReportRequest.php Outdated Show resolved Hide resolved
src/Request/ReportRequest.php Outdated Show resolved Hide resolved
@Saggre Saggre mentioned this pull request Aug 30, 2022
@Saggre
Copy link
Contributor

Saggre commented Aug 30, 2022

Some of the issues mentioned here have been fixed in #44

Taiteilija
Taiteilija previously approved these changes Sep 1, 2022
@loueranta-paytrail loueranta-paytrail merged commit 85bcc65 into master Sep 2, 2022
@loueranta-paytrail loueranta-paytrail deleted the payment_report_endpoint branch September 2, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants