This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
[WIP] feat(typescript): use JSX.IntrinsicElements for properties #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the use of `React.HTMLProps` and `React.SVGAttributes` with `JSX.IntrinsicElements`. Inspired by styled-components/styled-components#1084
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 172 172
Branches 47 47
=====================================
Hits 172 172Continue to review full report at Codecov.
|
4 tasks
|
I'm going to close this pr for now. I may pick this back up again when I get time, however if someone is interested in seeing this land feel free to run with it 🙂 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the use of
React.HTMLPropsandReact.SVGAttributeswithJSX.IntrinsicElements.Inspired by styled-components/styled-components#1084
What:
Replaces the use of
React.HTMLPropsandReact.SVGAttributeswithJSX.IntrinsicElements.Why:
The use of these came from when the typings were first based off
styled-component.How:
Checklist:
I haven't tested this thoroughly, so whilst it all seems fine, I'm not sure this is ok to land just yet. I'll try and do some testing with a large glamorous codebase in the coming days.