Introducing PodStatusHooks #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmadhan01
commented
Sep 26, 2019
- Addresses New Plugin Interface for custom hooks around Executor API methods #75 (comment)
Allow hooks extensibility by pushing pod/task status to a channel fix config key used to fetch configured hooks move general, example plugins to pluginimpl directory bug fixes and unit tests fix go imports
kkrishna
reviewed
Sep 27, 2019
plugin/type.go
Outdated
| Execute(podStatus string, data interface{}) error | ||
| // BestEffort is invoked in case a Execute returned an error and is expected to return a bool to indicate | ||
| // if the execution needs to continue with the next available hook or not | ||
| BestEffort() bool |
There was a problem hiding this comment.
Good point. Need this to determine whether execution need to proceed to next available hook. It would be better to pass this data in Execute( ) response such as (bool, error). Combining BestEffort() with Execute, as well would make it flexible to handle various situations -- some may be best effort while others could be not.
There was a problem hiding this comment.
Yeah, makes sense to combine this or introduce a custom error type. I will make that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.