Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper height data for animated gifs #2506

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

denolfe
Copy link
Member

@denolfe denolfe commented Apr 17, 2023

Description

Fixes #2439

When reading from buffer, animated gifs aggregate the image height for each frame. The number of frames in an animated image is now taken into account when calculating the image data.

  • I have read and understand the CONTRIBUTING.md document in this repository

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@denolfe denolfe force-pushed the fix/gif-resize-data branch from 3b0fd0a to 1427d1f Compare April 17, 2023 15:11
@denolfe denolfe merged commit aee6ca0 into master Apr 17, 2023
@denolfe denolfe deleted the fix/gif-resize-data branch April 17, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animated Gif: Wrong media height
1 participant