Fix: Payment price is always shown in checkout #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `getPrice()` on `$paymentmethod` returns a price object. Therefore the if always returns true and the price for the payment option is always shown in checkout. Apparently OXID/Smarty does not like chaining methods in an if so we can't do `->getPrice()->getBruttoPrice()`. Using another if fixes this problem and the price is only shown if a price is set for the payment option.
…yment-price-check fix: corrects payment price check
|
@payeverdev, any feedback on this pull request? (Sorry for bumping, but it's been almost a year since I opened the pull request) |
|
Dear JanWennrichPCSG, thanks for your contribution! Sorry we didn't reply before, we seem to have overlooked your last comment. This is not our development repo so we can not merge that in here, but we're going to take a look at your suggested change and if it passes all our tests with no issues, we will include it when launching the next version of our oxid plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
getPrice()on$paymentmethodreturns a price object.Therefore the if always returns true and the price for the payment option is always shown in checkout.
Apparently OXID/Smarty does not like chaining methods in an if so we can't do
->getPrice()->getBruttoPrice().Using another if fixes this problem and the price is only shown if a price is set for the payment option.