Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set bom pom version to correct number and maven fix #11

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Set bom pom version to correct number and maven fix #11

merged 1 commit into from
Sep 17, 2019

Conversation

Cousjava
Copy link

No description provided.

@Cousjava Cousjava requested a review from dmatej September 17, 2019 08:24
@dmatej
Copy link

dmatej commented Sep 17, 2019

Add also javadocs/pom.xml ;)

@Cousjava Cousjava force-pushed the 2.6.1.payara-maintenance branch from 2ac6f19 to b46cdab Compare September 17, 2019 08:34
dmatej
dmatej suggested changes Sep 17, 2019
View reviewed changes
Copy link

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test my changes before commiting them ;)

@dmatej dmatej self-requested a review September 17, 2019 09:39
dmatej
dmatej approved these changes Sep 17, 2019
View reviewed changes
Copy link

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't apply my changes, the PR is correct.

@dmatej dmatej merged commit e6178ec into payara:2.6.1.payara-maintenance Sep 17, 2019
@dmatej
Copy link

dmatej commented Sep 17, 2019 •
edited
Loading

And now I can go with my changes in #10

@dmatej dmatej mentioned this pull request Sep 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatej dmatej dmatej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cousjava @dmatej