CUSTCOM-83 Infinite Loop Causing CPU Hogging 2.3.31 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent endless loops if the SSL connection is terminated early without enough data. Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
Cousjava
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the first commit for the actual changes. To summarise this issue:
In some scenarios, an SSL connection is terminated before data is fully sent. In this case, the SSLBaseFilter will currently keep passing the incomplete data down the chain. An infinite loop was caused by the data handling filters deciding there's not enough data, and restarting the chain. This change makes sure that the SSLBaseFilter doesn't try to repeatedly process incomplete data on a terminated SSL connection