Payara issue 502.2 #504
Payara issue 502.2 #504
Conversation
- resource bundle the could not be found from jdbc-runtime where it is used.
…a resource bundle - fixes the issue together with the previous commit
…another jar file
- removed anonymous class - removed synchronization hell - KISS - respecting other threads without need of synchronization - looking for a resource bundle outside logger - looking for a resource bundle via provided class loader - constructing names makes sense (a bit) - seems faster and no voodoo needed any more - commented out System.x.println logs for extreme situations # Conflicts: # nucleus/common/common-util/src/main/java/com/sun/logging/LogDomains.java
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
payara test please |
- API method for loggers which never use bundled messages so the resource bundle searching will be skipped.
- container-common.jar
- connectors-runtime.jar - deleted copied commented out code
|
All tests have passed |
- uses bundle from another jar file, then must use also it's logger - conflicting package names!
- added bundle file - some messages moved here from nucleus security core because they are not used in any other place
…ity core - checked by fulltext searching over the whole repository
- class has no bundle available and messages are not anywhere in classpath
- truncated whitespaces - some loggers don't use bundles
|
payara test please |
|
All tests have passed |
|
Similar to the other comments on the other pull requests One thing we need changing to comply with the CDDL we need a comment in each changed file of the form; Portions Copyright [2015] [C2B2 Consulting Limited] Can you add please? |
|
Given the number of changes on this pull request we can get one of our developers to add the comments if you don't have time. |
|
I'm in half of the work ... what to do with files that are completely new? Should I add still the same header? (Portions ...) |
|
Completely new files should have /*
DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
Copyright (c) 2015 C2B2 Consulting Limited. All rights reserved.
The contents of this file are subject to the terms of the Common Development
and Distribution License("CDDL") (collectively, the "License"). You
may not use this file except in compliance with the License. You can
obtain a copy of the License at
https://glassfish.dev.java.net/public/CDDL+GPL_1_1.html
or packager/legal/LICENSE.txt. See the License for the specific
language governing permissions and limitations under the License.
When distributing the software, include this License Header Notice in each
file and include the License file at packager/legal/LICENSE.txt.
*/ |
|
Done :-) |
|
payara test please |
|
All tests have passed |
|
Can one of the admins verify this patch? |
9 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
FISH-5746 Fix the getOptionalValues NoSuchElementException
And this is the second part. It contains much more changes, but it seems much better in my opinion ... but I'm not sure if it is completely correct. Someone should check it.
This part also should help to resolve similar issues ...