CUSTCOM-199 Fix REST management JSON requests #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
cubastanley
approved these changes
Feb 18, 2020
Cousjava
approved these changes
Feb 18, 2020
AlanRoth
approved these changes
Feb 18, 2020
|
jenkins test please |
The REST management interface couldn't be invoked via a JSON request, since the parameters would be read into the map as a JSONStringImpl, which still contains the wrapping quotation marks. This means that all of the parameters would be wrong. This commit uses the toString method of the values read rather than hard casting to make sure the correct values are parsed. Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
|
Jenkins test please |
dmatej
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix.
The REST management interface couldn't be invoked via a JSON request, since the parameters would be read into the map as a JSONStringImpl, which still contains the wrapping quotation marks. This means that all of the parameters would be wrong. This commit uses the toString method
of the values read rather than hard casting to make sure the correct values are parsed.