APPSERV-22 Remove Derby #4451
APPSERV-22 Remove Derby #4451
Conversation
* Database related asadmin commands * Core code of JBatch
… passing even after failing to insert data into the database
There was a problem hiding this comment.
Very impressive that you could pull this change off - but also very scary - the amount of files that needed to change and the level of duplication that is apparently going on in this old code.
Only have some minor comments.
As I am not knowledgeable on the role of derby in connection with the server I could only look at the changes made but I cannot say anything about changes that were not made but maybe should have been. Therefore I feel someone with a better idea on this should also take a look at this PR.
I am going to run suggested tests - if they come out clean I am happy with this PR as is.
Edit: Note to all other reviewers: Make sure to review with whitespace changes not being shown ;)
| @@ -211,8 +206,6 @@ public void init(IBatchConfig batchConfig) throws BatchContainerServiceException | |||
| public CheckpointData getCheckpointData(CheckpointDataKey key) { | |||
| logger.entering(CLASSNAME, "getCheckpointData", key == null ? "<null>" : key); | |||
|
|
|||
| tryObtainTableLock(); | |||
There was a problem hiding this comment.
I assume this is not needed for H2 for some reason?
There was a problem hiding this comment.
This was written specifically for Derby
...nnector/src/main/java/fish/payara/jbatch/persistence/rdbms/JBatchJDBCPersistenceManager.java
Outdated
Show resolved
Hide resolved
appserver/tests/quicklook/ejb/cmp/src/java/client/RosterServlet.java
Outdated
Show resolved
Hide resolved
* Removed the debug print line
|
See Jira for details of DO NOT MERGE |
|
Jenkins test please |
1 similar comment
|
Jenkins test please |
…Derby during the JDBC Connection pool creation.
|
Jenkins test please |
Description
We've bundled both the H2 and Derby databases when only one is required.
Important Info
Dependant PRs
Test suites executed
Testing Environment
Zulu JDK 1.8_222 on Elementary OS 0.4.1 Loki with Maven 3.5.4>