-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAYARA-4097 Fixed Grid Layout, Dynamic Settings #4225
Conversation
jenkins test please |
jenkins test please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! However, I'm not sure if you implemented it but I was not able to remove any charts that I added, and are you able to add charts to monitor instances other than server?
@AlanRoth Removing charts is implemented but I discovered that I broke it recently (and fixed it later). Other instances can be monitored. Just start one and if it has a series with non zero value it should occur in the chart and also in the list of instances. I might also have broken something there recently since the list of instances actually has an effect of the shown data. Have to check. |
@AlanRoth Other instances still works. Just create them and the core tab should start showing multiple lines. |
@AlanRoth Since I already fixed the issue with chart removal in another branch I hope it is ok for you if we keep it in this one as it is not related to the feature of this PR and was caused by general code reorganisation I have to do every now and then in the JS code to keep it readable. Slowly I learn how to do that without it growing to big or confusing. |
Summary
Pure JS/HTML/CSS update for MC webapp that does:
MonitoringConsole
)Reviewer Notes
Remember that
monitoring-console.js
is merged from the other JS files and does not need to be reviewed.