PAYARA-4104 Fixes NPE in monitoring console startup in case hazelcast is disabled

[jbee]

PR fixes error reported in #4186 .

[jbee]

jenkins test please

[cubastanley]

\o/

[AlanRoth]

I quickbuild and skiptests on Windows 10, maybe environment issue but looks related?

./asadmin start-domain
Exception in thread "main" java.lang.IllegalStateException: The service 'org.glassfish.hk2.api.DynamicConfigurationService' could not be located by the locator 'ServiceLocatorImpl(__HK2_Generated_0,0,1909546776)'!
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.getServiceOrFail(AbstractModulesRegistryImpl.java:141)
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.initializeServiceLocator(AbstractModulesRegistryImpl.java:124)
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.newServiceLocator(AbstractModulesRegistryImpl.java:119)
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.createServiceLocator(AbstractModulesRegistryImpl.java:197)
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.createServiceLocator(AbstractModulesRegistryImpl.java:203)
        at com.sun.enterprise.module.single.StaticModulesRegistry.createServiceLocator(StaticModulesRegistry.java:64)
        at com.sun.enterprise.admin.cli.CLIContainer.getServiceLocator(CLIContainer.java:212)
        at com.sun.enterprise.admin.cli.CLIContainer.getLocalCommand(CLIContainer.java:244)
        at com.sun.enterprise.admin.cli.CLICommand.getCommand(CLICommand.java:240)
        at com.sun.enterprise.admin.cli.AdminMain.executeCommand(AdminMain.java:362)
        at com.sun.enterprise.admin.cli.AdminMain.doMain(AdminMain.java:298)
        at org.glassfish.admin.cli.AsadminMain.main(AsadminMain.java:56)

[jbee]

@AlanRoth Does not look related to me but we can wait with the merge and look for more insight.

[AlanRoth]

@jbee If you think it's unrelated, you're free to merge. :)

[svendiedrichsen]

@jbee Would this fix lead to a release of Payara 5.193.1?

[dmatej]

@AlanRoth Usually this is caused by one of these (on Linux):

• JDK11 as default java program (no AS_HOME or JAVA_HOME set)
• some instance is already running

[jbee]

@svendiedrichsen I have a chat internal on a 5.193.1 release.

[AlanRoth]

Ignore my last comment, fix works :)

[jbee]

@svendiedrichsen We feel that turning of hazelcast on DAS is so uncommon that a release isn't justified. There is an easy enough workaround in removing the monitoring-console-core.jar from glassfish/modules that can be applied by those that use the setting.

[svendiedrichsen]

@svendiedrichsen We feel that turning of hazelcast on DAS is so uncommon that a release isn't justified. There is an easy enough workaround in removing the monitoring-console-core.jar from glassfish/modules that can be applied by those that use the setting.

Thanks for the info, @jbee .