PAYARA-4065 Ensure that the threadpools are correctly initialized even when Embedded server is restarted #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...xecutor-service/src/main/java/fish/payara/nucleus/executorservice/PayaraExecutorService.java
Outdated
Show resolved
Hide resolved
2860f71 to
99d700f
Compare
|
jenkins test please |
1 similar comment
|
jenkins test please |
pdudits
suggested changes
Aug 13, 2019
...xecutor-service/src/main/java/fish/payara/nucleus/executorservice/PayaraExecutorService.java
Outdated
Show resolved
Hide resolved
...xecutor-service/src/main/java/fish/payara/nucleus/executorservice/PayaraExecutorService.java
Outdated
Show resolved
Hide resolved
… started that it is correctly initialized.
99d700f to
3d02442
Compare
|
jenkins test please |
pdudits
approved these changes
Aug 14, 2019
cubastanley
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there was a previous attempt to do this in place, it failed if the shutdown of the thread pool took any amount of time. And thus calling
stop()and thenstart()in rapid succession would fail. This change attempts to eliminate this scenario