SPEC-282: Introduce JVM option to turn off variable support outside config #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performing variable expansion in descriptors is not spec compliant, therefore it needs to be switched off for TCK tests. The system property is called fish.payara.substitution.disable and needs to be set to true in order to disable the feature. Some of the expansions need to be done regardless of the setting, therefore the original method was split into two.
jbee
approved these changes
Aug 8, 2019
| result = (T) TranslatedConfigView.getTranslatedValue(result); | ||
| if (type == String.class) { | ||
| result = (T) TranslatedConfigView.expandValue((String) result); | ||
| } |
There was a problem hiding this comment.
Is the else case handled elsewhere?
There was a problem hiding this comment.
getTranslatedValue does transformation only on Strings. I think the story is, that it inherited too general signature, when it was extracted from the interceptor-style method invoke before 2011.
|
jenkins test please |
jGauravGupta
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing variable expansion in descriptors is not spec compliant, therefore it needs to be switched off for TCK tests. The system property is called
fish.payara.substitution.disableand needs to be set to true in order to disable the feature.Some of the expansions need to be done regardless of the setting, therefore the original method was split into two.