SPEC-267: Fail operations on expired nonpersistent timers #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec mandates throwing an exception on accessing nonpersistent expired timers when accessed over public API. Since NonPersistentEJBTimerService is base class for persistent implementations, which pass their non-persistent functionality to it, it needs internal method for verifying it would handle that timer.
|
jenkins test please |
smillidge
approved these changes
Aug 7, 2019
jGauravGupta
approved these changes
Aug 8, 2019
jGauravGupta
reviewed
Aug 8, 2019
| cancelTimerSynchronization(null, timerId, | ||
| rt.getContainerId(), ownerIdOfThisServer_, false); | ||
| if (rt == null) { | ||
| return false; |
There was a problem hiding this comment.
In case of cancellation, If a timer is null or already canceled then the container must throw javax.ejb.NoSuchObjectLocalException instead of FinderException (EJB Spec 3.2 - Section 13.4.4 Timer Cancellation).
There was a problem hiding this comment.
Yes. This exception is wrapped into NoSuchObjectLocalException in TimerWrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec mandates throwing an exception on accessing nonpersistent
expired timers when accessed over public API.
Since NonPersistentEJBTimerService is base class for persistent
implementations, which pass their non-persistent functionality to it,
it needs internal method for verifying it would handle that timer.
This fixed ejb32/lite/timer tests, while not breaking ejb30/timer/tests at same time.