SPEC-245: Support embedded EJBContainer #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal modules should depend on repackages lib to prevent duplicates Distribution fragment's dependencies should not be optional by default
The server starts without any network ports started, RestMonitoringAdapter needs to cope with that Server is actually started twice in the container initialization sequence, PayaraExecutorService needs to reinitialize in such case.
|
Jenkins test please |
arjantijms
approved these changes
Aug 5, 2019
Pandrex247
reviewed
Aug 5, 2019
appserver/ejb/ejb-container/src/main/java/com/sun/ejb/containers/EJBTimerService.java
Outdated
Show resolved
Hide resolved
|
jenkins test please |
Pandrex247
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCK uses
glassfish-embedded-static-shellto launch an embedded container, that is isolated from installed domain but inherits domain's settings. This module needed broader dependencies, which uncovered issues in request tracing related modules.The startup of embedded container is quite special. First, it doesn't start with HTTP ports, which
RestMonitoringServicedoesn't expect and needed to handle. Second the server starts up twice -- once to get security configuration to copy, and second time to run with this new configuration.PayaraExecutorServicehad to be adapted to cope with double startup.Also added fix for cases where an EJB injects a
TimerServicebut doesn't use it. Before we wouldn't initialize any service and injection would fail.Also present in this bunch is fix for failing async methods on stateful EJBs. Apparently, these do not have ejb invocation context, which came as a surprise to context deserialization method.