PAYARA-3950 Process all properties files #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -426,9 +428,9 @@ private Properties getPropertiesFromFile(ClassLoader appClassLoader, String file | |||
| try (InputStream is = url.openStream()) { | |||
| p.load(url.openStream()); | |||
There was a problem hiding this comment.
Is this call twice to url.openStream intentional or should the variable is be used instead of the second call?
There was a problem hiding this comment.
Clearly I was so focused on fixing my problem I didn't review the code for additional issues!
smillidge
approved these changes
Jun 14, 2019
|
Jenkins test please |
Cousjava
approved these changes
Jun 17, 2019
MattGill98
approved these changes
Jun 17, 2019
|
This needs an internal Jira reference. |
|
Internally tracked by PAYARA-3950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4049