PAYARA-3917 SonarQube - Optimizing String.lastIndexOf() for single char in nucleus #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbee
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
@dvmarcilio Thank you for the contribution. I don't think you need to sign our CLA for this change. @smillidge Do you agree on the CLA?
|
jenkins test please |
|
@jbee I actually sent the CLA by e-mail this morning. But either way is fine with me. May I open more pull requests with more issues fixes? |
|
Yep CLA has been received |
|
@dvmarcilio Great. Sure, help is always welcome. If possible please assign the sonar issues you work on to you so we know they are taken care off. |
AlanRoth
approved these changes
Jun 10, 2019
AlanRoth
pushed a commit
to AlanRoth/Payara
that referenced
this pull request
Aug 13, 2019
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
AlanRoth
pushed a commit
to AlanRoth/Payara
that referenced
this pull request
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains fixes only for module nucleus.
Replacing
String.lastIndexOf("/")withString.lastIndexOf('/')which can be more performant.This fixes SonarQube violations of the rule: String function use should be optimized for single characters