PAYARA-3736: Let HazelcastConfigSpecificConfiguration register itself #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into domain After HK2 upgrade, the @nAmed annotation prevents the config object to be added into config automatically.
|
Jenkins test please |
arjantijms
approved these changes
May 27, 2019
This may need further investigation? |
No, it is known issue (next step in migration guide is adding relevant JVM options). However internal issue was created ti possibly automate that step via |
AlanRoth
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After HK2 upgrade, the
@Namedannotation prevents the config object to beadded into config automatically.
To test, backup a Payara4 domain, and restore it into Payara5. Before it failed because of this injection not being satisfied, now it will only compain about missing Grizzly ALPN classes (but will start).