PAYARA-3805 Cannot edit, add, or delete JVM options from Admin Console #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cubastanley
reviewed
May 16, 2019
| @@ -352,10 +352,10 @@ private String getErrorMessage(Map<String, String> data, ActionReport ar) { | |||
| results.put(key, entry.getValue()); | |||
| } else { | |||
| options.append(sep).append(removeVersioning ? new JvmOption(key).option : key); | |||
|
|
|||
cubastanley
approved these changes
May 16, 2019
|
Jenkins test please |
jbee
reviewed
May 16, 2019
.../rest-service/src/test/java/fish/payara/admin/rest/resources/CollectionLeafResourceTest.java
Show resolved
Hide resolved
jbee
approved these changes
May 16, 2019
Pandrex247
approved these changes
May 16, 2019
|
@jbee It's using TestNg assert equals rather than Junit assert equals - they take expected and actual in reverse of each other (which is just lovely and will never lead to confusion) |
AlanRoth
pushed a commit
to AlanRoth/Payara
that referenced
this pull request
Aug 13, 2019
Updated versions to align with CQs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was caused by '-XX:NewRatio=2' as previously it was assumed -X command-line options didn't require a value like in -D command-line options.