PAYARA-3709 Equals sign is added to system properties with empty value even if it's already in the key #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 5, 2019 15:12
cubastanley
reviewed
Apr 10, 2019
cubastanley
approved these changes
Apr 10, 2019
Pandrex247
previously requested changes
Apr 11, 2019
...st/rest-service/src/main/java/org/glassfish/admin/rest/resources/CollectionLeafResource.java
Outdated
Show resolved
Hide resolved
...st/rest-service/src/main/java/org/glassfish/admin/rest/resources/CollectionLeafResource.java
Outdated
Show resolved
Hide resolved
|
Alan is making further changes, hence the DO NOT MERGE label |
added 5 commits
April 11, 2019 11:01
update PAYARA-3709 branch
That was from a different solution to the test
MarkWareham
reviewed
Apr 12, 2019
.../rest-service/src/test/java/fish/payara/admin/rest/resources/CollectionLeafResourceTest.java
Outdated
Show resolved
Hide resolved
cubastanley
approved these changes
Apr 12, 2019
MarkWareham
reviewed
Apr 15, 2019
| options.append("=").append(entry.getValue()); | ||
|
|
||
| if (key != null && !key.trim().isEmpty() && key.startsWith("-D")) { | ||
| if (value == null || value.equals("null")) { |
There was a problem hiding this comment.
Could the text "null" ever be a valid value?
There was a problem hiding this comment.
Upon further thought, I think it should be accepted, "null" is a perfectly valid Gaelic name.
MarkWareham
approved these changes
Apr 15, 2019
MattGill98
suggested changes
Apr 15, 2019
.../rest-service/src/test/java/fish/payara/admin/rest/resources/CollectionLeafResourceTest.java
Outdated
Show resolved
Hide resolved
added 4 commits
April 15, 2019 11:30
Instead of listing separate nbproject directories
MattGill98
approved these changes
Apr 15, 2019
|
jenkins test please |
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 12, 2019
PAYARA-3709 Equals sign is added to system properties with empty value even if it's already in the key
AlanRoth
pushed a commit
to AlanRoth/Payara
that referenced
this pull request
Aug 13, 2019
* FIX payara#3849: Add vnd.api+json to the media types logged by PAYLOAD_TEXT Verbosity Signed-off-by: Arjun Vikram <arjvik@gmail.com>
Cousjava
pushed a commit
to Cousjava/Payara
that referenced
this pull request
Aug 21, 2019
PAYARA-3709 Equals sign is added to system properties with empty value even if it's already in the key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.