PAYARA-3676 PAYARA-3665 Fix More Asadmin Prompt Issues #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbee
reviewed
Mar 28, 2019
nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/LoginCommand.java
Outdated
Show resolved
Hide resolved
jbee
suggested changes
Mar 28, 2019
nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/LoginCommand.java
Show resolved
Hide resolved
nucleus/admin/cli/src/main/java/com/sun/enterprise/admin/cli/remote/RemoteCLICommand.java
Show resolved
Hide resolved
jbee
approved these changes
Mar 29, 2019
Cousjava
suggested changes
Mar 29, 2019
Cousjava
approved these changes
Mar 29, 2019
|
Jenkins test please |
1 similar comment
|
Jenkins test please |
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 12, 2019
…ompt-Issues PAYARA-3676 PAYARA-3665 Fix More Asadmin Prompt Issues
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 12, 2019
…a#618)" This reverts pull request payara#618. > * Merge pull request payara#3870 from Pandrex247/PAYARA-3676-Asadmin-Prompt-Issues > > PAYARA-3676 PAYARA-3665 Fix More Asadmin Prompt Issues > > > * PAYARA-3665 Merge conflicts > > > > Notable changes are in the second commit: String vs. char
AlanRoth
pushed a commit
to AlanRoth/Payara
that referenced
this pull request
Aug 13, 2019
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
AlanRoth
pushed a commit
to AlanRoth/Payara
that referenced
this pull request
Aug 13, 2019
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
Cousjava
pushed a commit
to Cousjava/Payara
that referenced
this pull request
Aug 21, 2019
…ompt-Issues PAYARA-3676 PAYARA-3665 Fix More Asadmin Prompt Issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much more aggressive use of JLine to hopefully catch any remaining issues around asadmin prompts exiting after a single input character.
Fixes #3833