PAYARA-3723 Fixing sonar blocker bugs with unclosed resources and potential NPE #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
MattGill98
approved these changes
Apr 1, 2019
Pandrex247
reviewed
Apr 3, 2019
| import org.glassfish.appclient.client.acc.JWSACCClassLoader; | ||
| import org.glassfish.appclient.common.Util; | ||
|
|
||
| import javax.swing.*; |
There was a problem hiding this comment.
Minor point, but is this necessary? Aren't we only using one class from here?
|
|
||
| private byte[] serialize(Object obj) throws IOException { | ||
| try(ByteArrayOutputStream bos = new ByteArrayOutputStream(); | ||
| ObjectOutputStream oos = getFactory().createObjectOutputStream(bos)) { |
There was a problem hiding this comment.
Formatting is a little off here, makes this a bit hard to read as this line looks like it belongs with the ones below.
There was a problem hiding this comment.
This is actually 2 Closables in one try-with-resources block. To have them both automatically closed. I have made now 2 try blocks to make clearer.
| return JsonbBuilder | ||
| .create() | ||
| .fromJson(objectValue.toString(), type); | ||
| try(Jsonb jsonb = JsonbBuilder.create()) { |
There was a problem hiding this comment.
Super minor, you missed a space between try and (
| @@ -245,6 +243,12 @@ private AuthenticationStatus validateAuthorizationCode(HttpMessageContext httpCo | |||
| } | |||
| } | |||
|
|
|||
| private JsonObject readJsonObject(String tokensBody) { | |||
| try(JsonReader reader = Json.createReader(new StringReader(tokensBody))) { | |||
There was a problem hiding this comment.
Same as other comment, just nitpicking formatting here
|
@Pandrex247 I have made the requested code changes. |
cubastanley
approved these changes
Apr 8, 2019
|
Jenkins test please |
Pandrex247
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.