PAYARA-3708 Implemented fixes for JLine Logging #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
Cousjava
approved these changes
Mar 27, 2019
Pandrex247
approved these changes
Mar 29, 2019
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 12, 2019
…Logging-Fixes PAYARA-3708 Implemented fixes for JLine Logging
Cousjava
pushed a commit
to Cousjava/Payara
that referenced
this pull request
Aug 21, 2019
…Logging-Fixes PAYARA-3708 Implemented fixes for JLine Logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request is made to complement the changes made by #3757. In particular, the following 2 cases were not considered:
asadmincommand outside of multimodeThe gist of the changes was to move the
checkToDisableJLineLoggingmethod to theCLICommandclass first and then allow an static initializer to disable the JLine logging before any interaction with a JLine reader is made.