Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2965 update hk2 to 2.5.0 #3855

Merged
merged 4 commits into from
Apr 8, 2019
Merged

PAYARA-2965 update hk2 to 2.5.0 #3855

merged 4 commits into from
Apr 8, 2019

Conversation

mulderbaba
Copy link
Contributor

No description provided.

@mulderbaba mulderbaba added this to the 5.192 milestone Mar 20, 2019
@mulderbaba mulderbaba self-assigned this Mar 20, 2019
@mulderbaba mulderbaba force-pushed the PAYARA-2965-Update-hk2-to-2.5.0 branch 2 times, most recently from 541b358 to a5fe79e Compare March 20, 2019 21:43
@mulderbaba
Copy link
Contributor Author

jenkins test

1 similar comment
@mulderbaba
Copy link
Contributor Author

jenkins test

Cousjava
Cousjava suggested changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@Cousjava Cousjava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server fails to start with a bunch of OSGi errors

@mulderbaba mulderbaba force-pushed the PAYARA-2965-Update-hk2-to-2.5.0 branch from a5fe79e to 295eaa4 Compare March 21, 2019 12:30
@mulderbaba
Copy link
Contributor Author

jenkins test

@mulderbaba mulderbaba requested a review from Cousjava March 21, 2019 14:11
@mulderbaba
Copy link
Contributor Author

jenkins test

@Pandrex247 Pandrex247 changed the title Payara 2965 update hk2 to 2.5.0 PAYARA-2965 update hk2 to 2.5.0 Mar 29, 2019
MattGill98
MattGill98 reviewed Apr 1, 2019
View reviewed changes
mertcaliskan added 3 commits April 1, 2019 23:47
PAYARA-2965-Update-hk2-to-2.5.0
ac2c485
PAYARA-2965-Update-hk2-to-2.5.0
aa3bfbb 
- javax.inject is now -> jakarta.inject
- removed asm-repackaged since asm is now being used directly
- moved onto hk2 version 2.5.0.payara-p1
PAYARA-2965-Update-hk2-to-2.5.0
74bf424 
using prefixed groupId of tiger-types
@mulderbaba mulderbaba force-pushed the PAYARA-2965-Update-hk2-to-2.5.0 branch from 295eaa4 to 74bf424 Compare April 1, 2019 20:47
PAYARA-2965-Update-hk2-to-2.5.0
997fec4 
upgrade hk2 plugins version
@mulderbaba
Copy link
Contributor Author

jenkins test

@mulderbaba mulderbaba requested a review from MattGill98 April 2, 2019 07:24
@MarkWareham MarkWareham merged commit 79bb40d into payara:master Apr 8, 2019
Cousjava added a commit to Cousjava/Payara that referenced this pull request May 1, 2019
@Cousjava
Revert "Merge pull request payara#3855 from mulderbaba/PAYARA-2965-Up…
365347f 
…date-hk2-to-2.5.0"

This reverts commit 79bb40d, reversing
changes made to 373eaff.

HK2 changes made in original commit conflict with 32659d5
which also updated HK2
AlanRoth pushed a commit to AlanRoth/Payara that referenced this pull request Aug 13, 2019
@jansupol
Merge pull request payara#3855 from jansupol/copyright
ae9ca1f 
Fix copyright check using new plugin version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cousjava Cousjava Cousjava approved these changes

@Pandrex247 Pandrex247 Pandrex247 approved these changes

@MattGill98 MattGill98 MattGill98 approved these changes

Assignees

@mulderbaba mulderbaba

Labels
None yet
Projects
None yet
Milestone
5.192
Development

Successfully merging this pull request may close these issues.
6 participants
@mulderbaba @Cousjava @Pandrex247 @MattGill98 @OndroMih @MarkWareham