PAYARA-2288 Create a MicroProfile Settings Page into the Admin Console #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
|
Quick build and test passed! |
MattGill98
suggested changes
Aug 3, 2018
There was a problem hiding this comment.
Looks really good overall, nice work! Just a few functional comments:
- The 'config saved' message pushes the tabs down, I think it should appear below the tabs as with other pages.
- The opentracing link always links to the request tracing in the 'server-config'. Not sure how doable it is, but should it link to the currently selected config?
- I find the 'ordinal' page unintuitive. Would it be possible to have a table to set the ordinals for?
- The same as above for the property table. It seems to allow adding properties, but not seeing them.
MattGill98
approved these changes
Aug 17, 2018
|
Jenkins test please |
|
Quick build and test failed! |
|
Jenkins test please |
|
Quick build and test failed! |
|
Jenkins test please |
|
Quick build and test passed! |
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Aug 29, 2018
PAYARA-2288 Create a MicroProfile Settings Page into the Admin Console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.