Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2827 Add empty java config to prevent null pointer #2847

Conversation

Pandrex247
Copy link
Member

No description provided.

@Pandrex247 Pandrex247 added this to the Payara 5.183 milestone Jun 15, 2018
@Pandrex247 Pandrex247 requested a review from MattGill98 June 15, 2018 15:56
Copy link
Contributor

@MattGill98 MattGill98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we get the same problem in embedded?

@Pandrex247
Copy link
Member Author

Embedded uses a different domain.xml, and that already has some entries in.

@Pandrex247
Copy link
Member Author

Jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@Pandrex247 Pandrex247 merged commit 2038ed3 into payara:master Jun 18, 2018
@Pandrex247 Pandrex247 deleted the PAYARA-2827-NullPointer-when-editing-jvm-options branch June 18, 2018 08:36
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jun 18, 2018
…r-when-editing-jvm-options

PAYARA-2827 Add empty java config to prevent null pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants