Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2330 Add option to disable logging to file #2264

Merged
merged 3 commits into from
Jan 17, 2018
Merged

PAYARA-2330 Add option to disable logging to file #2264

merged 3 commits into from
Jan 17, 2018

Conversation

MeroRai
Copy link
Member

@MeroRai MeroRai commented Jan 15, 2018

No description provided.

@MeroRai MeroRai self-assigned this Jan 15, 2018
@MeroRai MeroRai requested a review from OndroMih January 15, 2018 11:50
@arjantijms arjantijms added this to the Payara 4.181 milestone Jan 15, 2018
@payara payara deleted a comment from payara-ci Jan 16, 2018
@payara payara deleted a comment from payara-ci Jan 16, 2018
@payara payara deleted a comment from payara-ci Jan 16, 2018
@MeroRai
Copy link
Member Author

MeroRai commented Jan 16, 2018

jenkins test please

@OndroMih
Copy link
Contributor

Looks good. Just too many changes picked up by github in GFFileHandler.java, probably because of changes in formatting. It would be good to revert changes on lines which weren't really changed so that it's obvious which code was really changed.

@OndroMih OndroMih requested a review from smillidge January 16, 2018 20:14
@MeroRai
Copy link
Member Author

MeroRai commented Jan 17, 2018

@OndrejM changes in GFFilehandler.java is due to code indentation.

@michaelranaldo
Copy link
Contributor

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@smillidge smillidge merged commit 7e0b95a into payara:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smillidge smillidge smillidge approved these changes

@OndroMih OndroMih OndroMih approved these changes

Assignees

@MeroRai MeroRai

Labels
None yet
Projects
None yet
Milestone
Payara 4.181
Development

Successfully merging this pull request may close these issues.
7 participants
@MeroRai @OndroMih @michaelranaldo @payara-ci @smillidge @fturizo @arjantijms