PAYARA-2257 Refactor Microprofile config implementation and add delete commands #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
|
Quick build and test passed! |
… simplify the internal services
2f30a56 to
5173f44
Compare
|
jenkins test please |
|
Quick build and test passed! |
lprimak
reviewed
Dec 7, 2017
There was a problem hiding this comment.
Everything looks good except for philosophical issues of code looking same in multiple places except for actual types and methods called. Perhaps clever use of reflection or Lombok (maybe duck typing) could cut the size of the code at least in half if not more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.