Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-1180, PAYARA-1189 Maven snapshots profile #1666

Merged
merged 9 commits into from
Jun 13, 2017
Merged

PAYARA-1180, PAYARA-1189 Maven snapshots profile #1666

merged 9 commits into from
Jun 13, 2017

Conversation

Cousjava
Copy link
Contributor

@Cousjava Cousjava commented Jun 9, 2017

No description provided.

@Cousjava Cousjava added this to the Payara 173 milestone Jun 9, 2017
@Cousjava
Copy link
Contributor Author

Cousjava commented Jun 9, 2017

jenkins test please

@Cousjava Cousjava changed the title Maven snapshots profile PAYARA-1180 Maven snapshots profile Jun 9, 2017
@payara-ci
Copy link
Contributor

All tests have passed

arjantijms
arjantijms reviewed Jun 12, 2017
View reviewed changes
appserver/distributions/payara-ml/pom.xml Outdated
<plugin>
<groupId>org.sonatype.plugins</groupId>
<artifactId>nexus-staging-maven-plugin</artifactId>
<version>1.6.7</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 1.6.8 as sonatype always makes a big point of projects using the latest version

arjantijms
arjantijms suggested changes Jun 12, 2017
View reviewed changes
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only the version number stands out as a minor thing

@Cousjava
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

One or more tests have failed

@arjantijms
Copy link
Contributor

jenkins test please

@payara-ci
Copy link
Contributor

One or more tests have failed

@Cousjava
Copy link
Contributor Author

Jenkins, would you kindly?

@payara-ci
Copy link
Contributor

All tests have passed

@Cousjava Cousjava mentioned this pull request Jun 13, 2017
Closed
@Cousjava
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

One or more tests have failed

@arjantijms
Copy link
Contributor

Jenkins, would you kindly?

@payara-ci
Copy link
Contributor

All tests have passed

@arjantijms arjantijms merged commit 8eeadd6 into payara:master Jun 13, 2017
@Cousjava Cousjava changed the title PAYARA-1180 Maven snapshots profile PAYARA-1180, PAYARA-1189 Maven snapshots profile Jun 13, 2017
@payara-ci
Copy link
Contributor

All tests have passed

@Cousjava Cousjava mentioned this pull request Jun 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Payara 173
Development

Successfully merging this pull request may close these issues.
4 participants
@Cousjava @payara-ci @arjantijms @fturizo