PAYARA-1133 Slow SQL logger should keep the top and slowest SQL traces #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce listener to an empty String to prevent the new default kicking in
|
Jenkins, would you kindly? |
|
One or more tests have failed |
|
jenkins test please |
|
One or more tests have failed |
|
jenkins test please |
|
One or more tests have failed |
|
jenkins test please |
|
One or more tests have failed |
lprimak
reviewed
Jun 15, 2017
| public String getTopQueries() { | ||
| purgeEntries(); | ||
|
|
||
| List<SQLTrace> sqlTraceList = new ArrayList(cache.values()); |
There was a problem hiding this comment.
Should be ArrayList<> instead of raw type
lprimak
approved these changes
Jun 15, 2017
|
Jenkins, would you kindly? |
1 similar comment
|
Jenkins, would you kindly? |
|
One or more tests have failed |
|
Jenkins, would you kindly? |
|
One or more tests have failed |
|
All tests have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the capability to monitor the slowest SQL traces executed against a connection pool.
To enable this, turn on monitoring of the JDBC Connection pools in a config, for example:
asadmin set server.monitoring-service.module-monitoring-levels.jdbc-connection-pool=HIGHIt is configured in the same way as the frequent SQL tracing, using the number-of-top-queries-to-report and time-to-keep-queries-in-minutes properties:
The monitoring figures can be viewed via the admin console (under Resources > Resource > JDBC Connection Pool Statistics), or using
asadmin get -m server.resources.<POOL_NAME>.slowSqlQueries-currentFor ease of use, I've also created a default SQL Trace listener that simply does nothing, as the monitoring of the slowest SQL traces requires an SQL Trace listener. This can be replaced with any other valid SQL Trace listener without affecting the monitoring (as far as I've tested anyway). The new default SQL Trace listener is now the default value of the sqlTraceListeners option for the create-jdbc-connection-pool command.
This PR also fixes monitoring of the most Frequent SQL Traces, though this still retains all of its previous shortcomings.