Payara 1578 incorporate improvements provided on usage of the smack api #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MultiUserChat.sendMessage() will take care of that.
The artifacts smack-core, jxmpp-core and jxmpp-util-cache are transitive dependencies of smack-java7. That is all we need to depend on. Also pinning JXMPP to a certain version may cause if a newer Smack version depends on a different, API-incompatible version.
added transitive dependencies back to packager
|
jenkins test please |
|
All tests have passed |
|
@smillidge this obsoletes PR#1510 and containing commits from @Flowdalic. build is ok now. |
|
jenkins test please |
|
One or more tests have failed |
|
jenkins test please |
|
One or more tests have failed |
|
jenkins test please |
|
All tests have passed |
smillidge
approved these changes
Apr 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.