Thread-safe initialization of InstanceResolverImpl. Fixes #1511. PAYARA-1577 #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolver guarded with proper double-check lock. Field instance only changes when resolver is initialized, therefore I believe it doesn't need any further synchronization.
|
Can one of the admins verify this patch? |
|
jenkins test please |
|
All tests have passed |
lprimak
previously requested changes
Apr 10, 2017
|
jenkins test please |
|
All tests have passed |
smillidge
approved these changes
Apr 11, 2017
mulderbaba
pushed a commit
to mulderbaba/Payara
that referenced
this pull request
Apr 13, 2017
… PAYARA-1577 (payara#1516) * Thread-safe initialization of InstanceResolverImpl. Fixes payara#1511. Resolver guarded with proper double-check lock. Field instance only changes when resolver is initialized, therefore I believe it doesn't need any further synchronization. * Add copyright
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jul 4, 2017
… PAYARA-1577 (payara#1516) * Thread-safe initialization of InstanceResolverImpl. Fixes payara#1511. Resolver guarded with proper double-check lock. Field instance only changes when resolver is initialized, therefore I believe it doesn't need any further synchronization. * Add copyright
lprimak
pushed a commit
to flowlogix/Payara
that referenced
this pull request
Jul 5, 2017
… PAYARA-1577 (payara#1516) * Thread-safe initialization of InstanceResolverImpl. Fixes payara#1511. Resolver guarded with proper double-check lock. Field instance only changes when resolver is initialized, therefore I believe it doesn't need any further synchronization. * Add copyright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolver guarded with proper double-check lock. Field instance only changes when resolver is
initialized, therefore I believe it doesn't need any further synchronization.