Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-1085 Changing admin-thread-pool config flags restart required #1492

Merged
merged 3 commits into from
Apr 3, 2017
Merged

PAYARA-1085 Changing admin-thread-pool config flags restart required #1492

merged 3 commits into from
Apr 3, 2017

Conversation

MattGill98
Copy link
Contributor

Restart required now shows when the admin thread pool configuration is changed.

@MattGill98
Copy link
Contributor Author

Jenkins test please

@payara-ci
Copy link
Contributor

One or more tests have failed

1 similar comment
@payara-ci
Copy link
Contributor

One or more tests have failed

@smillidge
Copy link
Contributor

jenkins test please

@payara-ci
Copy link
Contributor

All tests have passed

Copy link
Contributor

@Cousjava Cousjava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now throws exception on server startup:
java.lang.NullPointerException
at com.sun.enterprise.v3.services.impl.DynamicConfigListener.isRedundantChange(DynamicConfigListener.java:249)
at com.sun.enterprise.v3.services.impl.DynamicConfigListener.processNetworkListener(DynamicConfigListener.java:203)
at com.sun.enterprise.v3.services.impl.DynamicConfigListener.processVirtualServer(DynamicConfigListener.java:282)
at com.sun.enterprise.v3.services.impl.DynamicConfigListener.access$400(DynamicConfigListener.java:84)
at com.sun.enterprise.v3.services.impl.DynamicConfigListener$1.changed(DynamicConfigListener.java:144)
at org.jvnet.hk2.config.ConfigSupport.sortAndDispatch(ConfigSupport.java:336)
at com.sun.enterprise.v3.services.impl.DynamicConfigListener.changed(DynamicConfigListener.java:102)
at org.jvnet.hk2.config.Transactions$ConfigListenerJob.process(Transactions.java:401)
at org.jvnet.hk2.config.Transactions$ConfigListenerJob.process(Transactions.java:391)
at org.jvnet.hk2.config.Transactions$ConfigListenerNotifier$1$1.call(Transactions.java:281)
at org.jvnet.hk2.config.Transactions$ConfigListenerNotifier$1$1.call(Transactions.java:279)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
]]

@MattGill98
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

All tests have passed

@Pandrex247 Pandrex247 changed the title Changing admin-thread-pool config flags restart required PAYARA-1085 Changing admin-thread-pool config flags restart required Apr 3, 2017
@Pandrex247 Pandrex247 merged commit 0066744 into payara:master Apr 3, 2017
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jul 4, 2017
…ad-Pool-No-Restart-Message

PAYARA-1085 Changing admin-thread-pool config flags restart required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants