PAYARA-1509 condition for access logger may be read in from domain.xml #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, would you kindly? |
|
All tests have passed |
smillidge
requested changes
Mar 22, 2017
| @@ -74,6 +75,13 @@ public ConfigBeansUtilities(Applications paramApps, Domain paramDomain) { | |||
| domain = paramDomain; | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Why is this change needed if the default if not available will be null anyway?
There was a problem hiding this comment.
I wrote it this way to match how others are set, and I'm not sure if the default condition is meant to be null - the other defaults mention that they come from a dtd which I have not been able to find.
| @@ -908,6 +908,14 @@ void updateAccessLogAttributes(HttpService httpService, | |||
| historyFiles = new LinkedList<File>(); | |||
| } | |||
|
|
|||
| //Conditional access log | |||
| if (accessLogConfig != null) { | |||
There was a problem hiding this comment.
Why check if not null and then do an else that sets it to null. Why not just set it regardless and not bother with the getDefaultCondition change?
smillidge
approved these changes
Mar 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1450