Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-1467 Changed all references to 'connections' to 'beans' in the admin console #1428

Merged
merged 1 commit into from
Mar 3, 2017
Merged

PAYARA-1467 Changed all references to 'connections' to 'beans' in the admin console #1428

merged 1 commit into from
Mar 3, 2017

Conversation

MattGill98
Copy link
Contributor

Changed all references to 'connections' to 'beans' in the admin console on the configuration page for the EJB Container. Affected languages: German, Spanish, French, Italian, Portugese/Brazil and English. Didn't affect any non-latin languages.

…le on the configuration page for the EJB Container. Affected languages: German, Spanish, French, Italian, Portugese/Brazil and English. Didn't affect any unicode languages.
@MattGill98
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

One or more tests have failed

@Cousjava Cousjava changed the title Changed all references to 'connections' to 'beans' in the admin console PAYARA-1467 Changed all references to 'connections' to 'beans' in the admin console Mar 1, 2017
@Cousjava
Copy link
Contributor

Cousjava commented Mar 1, 2017

jenkins test please

@payara-ci
Copy link
Contributor

All tests have passed

Copy link
Contributor

@mulderbaba mulderbaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't replace the keywords from german, italian, spanish and other type of localed properties? IDE's usually fail with these type of refactoring.

@mulderbaba mulderbaba added this to the Payara 172 milestone Mar 2, 2017
@smillidge smillidge merged commit 8ab2ae1 into payara:master Mar 3, 2017
Pandrex247 pushed a commit that referenced this pull request Mar 27, 2017
…le on the configuration page for the EJB Container. Affected languages: German, Spanish, French, Italian, Portugese/Brazil and English. Didn't affect any unicode languages. (#1428)
Pandrex247 pushed a commit that referenced this pull request Mar 27, 2017
…le on the configuration page for the EJB Container. Affected languages: German, Spanish, French, Italian, Portugese/Brazil and English. Didn't affect any unicode languages. (#1428)
lprimak pushed a commit to flowlogix/Payara that referenced this pull request Jul 5, 2017
…le on the configuration page for the EJB Container. Affected languages: German, Spanish, French, Italian, Portugese/Brazil and English. Didn't affect any unicode languages. (payara#1428)
@MattGill98 MattGill98 deleted the PAYARA-1467-EJB-Container-Pool-Help-Text branch June 18, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants