PAYARA-1485-Create-notifier-for-New-Relic #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
|
All tests have passed |
Pandrex247
requested changes
Feb 28, 2017
appserver/admingui/pom.xml
Outdated
| @@ -110,7 +110,7 @@ | |||
| <module>cluster</module> | |||
| <module>payara-theme</module> | |||
| <module>web</module> | |||
| <module>gf-admingui-connector</module> | |||
| <module>gf-admingui-connector</module> | |||
| @Param(name = "key") | ||
| private String key; | ||
|
|
||
| @Param(name = "accountId") |
There was a problem hiding this comment.
You can use the alias Param option to specify lowercase as an acceptable alternative:
@Param(name = "accountId", alias = "accountid")
|
jenkins test please |
|
One or more tests have failed |
|
jenkins test please |
|
All tests have passed |
Pandrex247
approved these changes
Mar 6, 2017
|
@mulderbaba I merged the Dtadog notifier and now there are merge conflicts. |
|
@smillidge ok, resolved them. github now offers a cool editor for conflict resolution. |
|
jenkins test please |
|
One or more tests have failed |
fix on passing header parameter
|
jenkins test please |
|
All tests have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.