PAYARA-1134 make ROOT.war deploy to / context root #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmands not just when embedded
|
jenkins test please |
|
One or more tests have failed |
|
jenkins test please |
Pandrex247
requested changes
Oct 28, 2016
There was a problem hiding this comment.
You need to also include your check for when deploying using a GAV.
You can use my branch to test it with (currently still deploys to "/ROOT"):
java -jar payara-micro.jar --deployFromGAV fish.payara.testing,ROOT,1.1 --additionalRepository https://raw.github.com/Pandrex247/Payara_PatchedProjects/Payara-Maven-Deployer
…ith a context root of /
|
OK GAV should now work as well |
|
jenkins test please |
|
All tests have passed |
1 similar comment
|
All tests have passed |
Pandrex247
approved these changes
Oct 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Payara Micro make ROOT.war deploy to the / context root as it does after packaging as an Uber Jar