Don't cast cached Throwable to Exception as it's too narrow. (PAYARA-1126) #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasoning: JCache spec and Payara implementation allows caching of exceptions. In theory everything extending Throwable can be cached -> casting to Exception is not safe as it can throw ClassCastException
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
jenkins test please |
smillidge
approved these changes
Oct 23, 2016
|
All tests have passed |
lprimak
pushed a commit
to flowlogix/Payara
that referenced
this pull request
Jul 5, 2017
…1139) Reasoning: JCache spec and Payara implementation allows caching of exceptions. In theory everything extending Throwable can be cached -> casting to Exception is not safe as it can throw ClassCastException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning:
JCache spec and Payara implementation allows caching of exceptions.
In theory everything extending Throwable can be cached -> casting to
Exception is not safe as it can throw ClassCastException