Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestions] Remove search auto focus #122

Closed
wants to merge 1 commit into from
Closed

[Suggestions] Remove search auto focus #122

wants to merge 1 commit into from

Conversation

icedterminal
Copy link

Major annoyance for mobile devices. Mostly tablets that have large keyboards in landscape. You're forced to dismiss the keyboard every time you load the page.

Alternative: Make auto focus an option in settings.

Major annoyance for mobile devices. Mostly tablets that have large keyboards in landscape. You're forced to dismiss the keyboard every time you load the page.
@pawelmalak
Copy link
Owner

This PR doesn't solve the problem. While it will work for some users, it will also break UX for others. In the meantime you can use custom CSS to hide search bar on mobile devices:

@media (max-width: 500px) {
  .SearchBar_SearchBar__2Pbl1 {
    display: none !important;
  }
}

@pawelmalak pawelmalak closed this Oct 22, 2021
@icedterminal
Copy link
Author

Unfortunately the suggestion you offer doesn’t solve the problem either. It’s effectively the same as disabling the search box. Which isn’t desired. I like having it there should I need it.

While it will work for some users, it will also break UX for others.

Would you mind elaborating? I’ve been removing that bit of code each update without issue.

If removing isn’t your preference, would you be open to an autofocus option?

@pawelmalak
Copy link
Owner

While it will work for some users, it will also break UX for others.

What I meant, is that for you autofocus is annoying so you would delete it. But other user might like that when he opens the app, search bar is already focused so he can just start typing. If we delete that, he will have to manually focus it and it will be annoying for him.

I will add option in settings to disable/enable autofocus in next update.

@icedterminal
Copy link
Author

Ah ok. Appreciate the explanation. Thank you for making it an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants