Add kylemocode/react-lite-yt-embed #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garbee
reviewed
Mar 21, 2021
readme.md
Outdated
| @@ -64,6 +64,9 @@ Use this as your HTML, load the script asynchronously, and let the JS progressiv | |||
| </lite-youtube> | |||
| ``` | |||
|
|
|||
| ## Libraries Using Other Frameworks | |||
There was a problem hiding this comment.
Why do we want to put this one thing into its own section? I don't see a difference between this heading and "Other lite embeds" in terms of a reader. They are all alternative forms of this type of thing.
There was a problem hiding this comment.
Ok, I have reviewed both sections carefully and tried to combine them in a way that makes sense and offers the most information for users reading this section (so that they can make an informed decision on what they want to click on).
What do you think?
|
Thanks Karl. Sorry its all taken so long since the original issue. |
|
@paulirish no problem, thanks for the merge! By the way, reached out on Twitter DMs just now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22