Typescript support for Redux4 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldijou
reviewed
May 23, 2019
| @@ -1,11 +1,12 @@ | |||
| import * as tt from 'typescript-definition-tester' | |||
|
|
|||
| describe('TypeScript definitions', function () { | |||
| this.timeout(4000); | |||
There was a problem hiding this comment.
I don't know why, but some times compiler waist much time to process the whole test.
| a3 :createReducer<number>({ [act1.getType()]: () => 1 }, 0), | ||
| a4 :createReducer<boolean>(onOff, true), | ||
| a5 :createReducer<number>(onOff, 1) | ||
| }); |
There was a problem hiding this comment.
What's the advantage of combining rather than just creating them?
There was a problem hiding this comment.
It's a way to know about Reducer type compatibility between redux-act and redux Reducer type
| interface Reducer<S> { | ||
| (state: S, action: Redux.AnyAction): S | ||
| interface Reducer<S, A extends Redux.Action = Redux.AnyAction> { | ||
| (state: S | undefined, action: A): S |
There was a problem hiding this comment.
When would the state be undefined in the reduce function?
There was a problem hiding this comment.
Just for compatibility with redux Reducer type
It was updated on this PR: reduxjs/redux#2563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for Closes #99