Initial investigation into supporting a reactive content store #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
- by having a separate ReactiveStoreImpl fragment. This prevents NoClassDefFoundErrors on projects that dont use webflux
- for backward compatibility
migroskub
reviewed
Feb 26, 2022
...tent-s3/src/main/java/internal/org/springframework/content/s3/config/S3StoreFactoryBean.java
Show resolved
Hide resolved
...ntent-s3/src/main/java/internal/org/springframework/content/s3/store/DefaultS3StoreImpl.java
Outdated
Show resolved
Hide resolved
|
|
||
| private MappingContext mappingContext = new MappingContext(".", "."); | ||
|
|
||
| // reactive |
There was a problem hiding this comment.
I think these can be removed. The whole class is reactive
There was a problem hiding this comment.
The mappingcontext? Or the comments?
- refactor/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK. This is probably a good stopping point for now. Implemented a ReactiveContentStore.
Spring Content REST does NOT yet support this. It is Java API only. But I'd like to get feedback on that before plugging it into the REST layer.